Skip to content

Improve quote matcher performance #12418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 18, 2021
Merged

Improve quote matcher performance #12418

merged 4 commits into from
May 18, 2021

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki
Copy link
Contributor Author

test performance with #quotes please

@nicolasstucki nicolasstucki self-assigned this May 11, 2021
@dottybot
Copy link
Member

performance test scheduled: 3 job(s) in queue, 1 running.

@nicolasstucki
Copy link
Contributor Author

test performance with #quotes please

@dottybot
Copy link
Member

performance test scheduled: 5 job(s) in queue, 1 running.

@nicolasstucki
Copy link
Contributor Author

test performance with #quotes please

@dottybot
Copy link
Member

performance test scheduled: 5 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/12418/ to see the changes.

Benchmarks is based on merging with master (0ba5b55)

@nicolasstucki nicolasstucki force-pushed the improve-QuoteMatcher-performance branch from 7700c61 to ad08a67 Compare May 11, 2021 15:47
@nicolasstucki
Copy link
Contributor Author

test performance with #quotes please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/12418/ to see the changes.

Benchmarks is based on merging with master (4410752)

@nicolasstucki nicolasstucki force-pushed the improve-QuoteMatcher-performance branch from ad08a67 to e96a1be Compare May 17, 2021 15:34
@nicolasstucki nicolasstucki force-pushed the improve-QuoteMatcher-performance branch from e96a1be to cc34a88 Compare May 17, 2021 15:35
@nicolasstucki
Copy link
Contributor Author

test performance with #quotes please

@dottybot
Copy link
Member

performance test scheduled: 4 job(s) in queue, 1 running.

@nicolasstucki
Copy link
Contributor Author

Simpler to review commit by commit

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/12418/ to see the changes.

Benchmarks is based on merging with master (75edcf8)

@nicolasstucki nicolasstucki marked this pull request as ready for review May 17, 2021 18:00
@nicolasstucki nicolasstucki requested a review from liufengyun May 17, 2021 18:00
liufengyun
liufengyun approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 1bedf7a into scala:master May 18, 2021
@nicolasstucki nicolasstucki deleted the improve-QuoteMatcher-performance branch May 18, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @dottybot @liufengyun